Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nodeclass tag validation during instance create #7390

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

rschalo
Copy link
Contributor

@rschalo rschalo commented Nov 15, 2024

Fixes #N/A

Description
This tosses out kubernetes.io/ prefixed tags that are applied when bypassing CRD validation. Note that it does not filter out eks:eks-cluster-name because we overwrite that via static tags.

How was this change tested?
local CRD editing and launch instance tag validation:

map[eks:eks-cluster-name:<other-cluster-name> kubernetes.io/cluster/<other-cluster-name>:owned]

map[eks:eks-cluster-name:<other-cluster-name>]

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rschalo rschalo requested a review from a team as a code owner November 15, 2024 19:58
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit bc5d517
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6737a87ef7b09c00083a30b7

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) November 15, 2024 20:02
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11862656160

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 82.83%

Totals Coverage Status
Change from base Build 11861528984: 0.002%
Covered Lines: 5678
Relevant Lines: 6855

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit adb9f72 into aws:main Nov 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants