Update lsp-ci.yaml [DO NOT MERGE] #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As github replaces the [windows server version](https://github.blog/changelog/2025-01-30-larger-hosted-runner-enhancements-edit-runner-size-and-windows-server-4vcpu-runner-availability/), even though they indicate that [windows-latest = windows-2022](https://github.com/actions/runner-images?tab=readme-ov-file#available-images), our tests started to fail in the same time for windows. To check if it is the case, manually setting the windows version on github action to windows-2022
checking windows-2019
Checking with node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As github replaces the windows server version, even though they indicate that windows-latest = windows-2022, our tests started to fail in the same time for windows. To check if it is the case, manually setting the windows version on github action to windows-2022
Problem
Windows tests are failing on github actions
Solution
Instead of using
windows-latesmanually settingwindows-2022to check if that is the issue.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.