refactor: inject a sdk runtime initializator into servers to initialize sdk clients at runtime (fixed commit name issue) #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
February 3, 2025 14:01
francescoopiccoli
changed the title
imykhai
approved these changes
Feb 5, 2025
francescoopiccoli
deleted the
frapicc/fix-commit-name-issue-sdk-configurator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #767
this is exactly same changes but with correct commitlint names.
The lack of "chore" type before merge commit (42ae2f4), blocked merge into main. I could not find any easy solution to rename the commit from there, merge commits are somehow different from other commits.
Solution
git reset --hardto the commit before the merge and thencherry pickthe commits after the merge, finally merged main with the correct commit name.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.