refactor: remove proxy code (moved to runtimes) #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 3, 2025 14:01
Base automatically changed from
frapicc/fix-commit-name-issue-sdk-configurator
to
main
February 5, 2025 12:42
imykhai
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We moved the proxy setup to the runtimes repo with the introduction of the sdkInitializator. Since proxy setup is environment specific (we use it for nodejs envs only), and we want to keep capability servers environment-agnostic.
Solution
Removed the proxy code and moved it to the runtimes refer to the runtimes PR for the changes.
I tested the proxy manually, and I am currently investigating whether there is a way to automate tests for proxy, which in case would follow up in a new PR.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.