Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update rand requirement in /tools/xdp #2474

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Feb 14, 2025

Release Summary:

Resolved issues:

Description of changes:

Update dependency according to PR#2460. As mentioned in this comment, the latest rand release contains some breaking changes that we need to fix.

thread_rng() and gen_range() have been renamed to rand::rng() and random_range(). They have also been removed from rand::prelude. Hence, I have updated the function names and the used crate.

Call-outs:

For more details of the breaking change that rand release has introduced, refer to their release summary, and specifically to their PR that rename thread_rng().

Testing:

This PR will be tested by the existing tests in our CI. ci / xdp (pull_request) should pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang marked this pull request as ready for review February 14, 2025 20:51
@maddeleine
Copy link
Contributor

maddeleine commented Feb 15, 2025

Can you do all the crates instead of just xdp? Would be nice to fix the entire repo. You can do them in another commit though.

@maddeleine maddeleine merged commit 00e3371 into aws:main Feb 15, 2025
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants