cleanup: remove make fuzz and AFL fuzz #4808
Open
+33
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Sep 28, 2024
| 1. Compile with S2N_FUZZ_TEST option enabled | ||
| ``` | ||
| cmake . -Bbuild \ | ||
| -DCMAKE_PREFIX_PATH=/usr/local/$S2N_LIBCRYPTO \ |
There was a problem hiding this comment.
We should try and avoid CI-specific paths in public documentation. Also CMake should be able to find the libcrypto automatically.
Suggested change
| -DCMAKE_PREFIX_PATH=/usr/local/$S2N_LIBCRYPTO \ |
| AFL is deprecated and was removed in [#4808](https://github.com/aws/s2n-tls/pull/4808) |
There was a problem hiding this comment.
I'd vote to just totally remove this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Description of changes:
Call-outs:
This PR may not completely remove all Make and AFL fuzzing logic. We will continue to remove remainings as we find them.
Testing:
Verified CI tests pass by running the job against this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.