Add example notebooks to integ tests #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintaoz-aws
requested a deployment
to
manual-approval
GitHub Actions
Waiting
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
ef81310
to
764c500
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
764c500
to
06dc458
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
changed the title
pintaoz-aws
commented
Sep 13, 2024
| @@ -500,7 +500,8 @@ def _serialize_dict(value: Dict) -> dict: | |||
| """ | |||
| serialized_dict = {} | |||
| for k, v in value.items(): | |||
| if serialize_result := serialize(v): | |||
There was a problem hiding this comment.
The previous condition will miss values like integer 0
There was a problem hiding this comment.
Can we do if serialize_result := serialize(v) is not None: ?
nargokul
reviewed
Sep 13, 2024
Comment on lines
+75
to
+77
| trial_component.disassociate_trail(trial_name=trial.trial_name) | ||
| trial_component.delete() | ||
| trial.delete() |
There was a problem hiding this comment.
Can we move this to SageMakerCleaner so all resources cleanup is managed in one place ?
There was a problem hiding this comment.
TrialComponent must disassociate with Trial first, and they have to be deleted in the order TrialComponent -> Trial -> Experiment. So they can not be deleted in the way of deleting the same type of resources together
| @@ -500,7 +500,8 @@ def _serialize_dict(value: Dict) -> dict: | |||
| """ | |||
| serialized_dict = {} | |||
| for k, v in value.items(): | |||
| if serialize_result := serialize(v): | |||
There was a problem hiding this comment.
Can we do if serialize_result := serialize(v) is not None: ?
nargokul
reviewed
Sep 13, 2024
|
|
||
| assert invoke_result.body | ||
|
|
||
| invoke_result = endpoint.invoke_with_response_stream( |
There was a problem hiding this comment.
Test seems to be failing .
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
0110a52
to
5ac4f77
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
5ac4f77
to
1f50a79
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
1f50a79
to
3519265
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
force-pushed
the
sample-notebook-integ-test
branch
from
3519265
to
abf5867
Compare
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add the content in
track_local_pytorch_experiment.ipynbto integ test. AddEndpoint.invoke()andEndpoint.invoke_with_response_stream()to existing test. Fix some bugs found during testing.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.