Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bot): Guess os_distros based on changed files if not specified #1750

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

cartermckinnon
Copy link
Member

Description of changes:

It's nice for the CI workflow to scope down its jobs when a change only applies to one OS, but it's kind of a pain to declare this explicitly with e.g.:

+workflow:os_distros al2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cartermckinnon cartermckinnon changed the title [WIP] Guess CI os_distros if none is passed to bot [WIP] (bot) Guess os_distros based on changed files if not specified Apr 5, 2024
Copy link
Member

@Issacwww Issacwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change 🚀

Copy link
Member

@ndbaker1 ndbaker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a sweet idea 🥳

.github/actions/bot/index.js Outdated Show resolved Hide resolved
.github/actions/bot/index.js Outdated Show resolved Hide resolved
.github/actions/bot/index.js Outdated Show resolved Hide resolved
@cartermckinnon cartermckinnon changed the title [WIP] (bot) Guess os_distros based on changed files if not specified feat(bot): Guess os_distros based on changed files if not specified Jun 19, 2024
@cartermckinnon cartermckinnon added the changelog/exclude Exclude this PR from future changelog entries. label Jun 19, 2024
@cartermckinnon cartermckinnon merged commit a43da3f into awslabs:main Jun 19, 2024
10 checks passed
@cartermckinnon cartermckinnon deleted the bot-guess-os-distro branch June 19, 2024 16:54
mebays pushed a commit to mebays/amazon-eks-ami that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/exclude Exclude this PR from future changelog entries.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants