-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bot): Guess os_distros
based on changed files if not specified
#1750
Merged
cartermckinnon
merged 4 commits into
awslabs:main
from
cartermckinnon:bot-guess-os-distro
Jun 19, 2024
Merged
feat(bot): Guess os_distros
based on changed files if not specified
#1750
cartermckinnon
merged 4 commits into
awslabs:main
from
cartermckinnon:bot-guess-os-distro
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
bot-guess-os-distro
branch
from
April 5, 2024 00:05
adec708
to
7a96057
Compare
cartermckinnon
changed the title
[WIP] Guess CI
[WIP] (bot) Guess Apr 5, 2024
os_distros
if none is passed to botos_distros
based on changed files if not specified
Issacwww
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change 🚀
ndbaker1
reviewed
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a sweet idea 🥳
Co-authored-by: Nick Baker <[email protected]>
Co-authored-by: Nick Baker <[email protected]>
Co-authored-by: Nick Baker <[email protected]>
cartermckinnon
changed the title
[WIP] (bot) Guess
feat(bot): Guess Jun 19, 2024
os_distros
based on changed files if not specifiedos_distros
based on changed files if not specified
cartermckinnon
added
the
changelog/exclude
Exclude this PR from future changelog entries.
label
Jun 19, 2024
mebays
pushed a commit
to mebays/amazon-eks-ami
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
It's nice for the CI workflow to scope down its jobs when a change only applies to one OS, but it's kind of a pain to declare this explicitly with e.g.:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.