bug(al2): skip empty container images #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
added
the
changelog/exclude
|
/ci build |
ndbaker1
force-pushed
the
fix-install
branch
3 times, most recently
from
73df233
to
fe30a8a
Compare
|
had to redo the approach since the linter feel strongly about quoting array expansions /ci build |
|
@ndbaker1 the workflow that you requested has completed. 🎉
|
ndbaker1
changed the title
Issacwww
approved these changes
Aug 16, 2024
|
Thanks for the quick fix! 🚀 |
cartermckinnon
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
follow up for #1810. when there are no images to cache during worker installation, the blank variable
imgwill be passed to thepull-image.shscript.the reason for the issue is the fallback
"${VAR[@]:-}"still results in a single loop iteration over the empty string"", but would not do so with${VAR[@]:-}this PR short circuits when the loop variable is blank, which fixes this case and other cases where the image is actually blank, and also adds logging to help diagnose issues with the images in the future.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
build with the fix alleviates the issue.