feat(nodeadm): use cached kubelet version to reduce config time #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node logs are now collected for CI jobs: #2010 I'll use those to establish a baseline. /ci |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
|
Some baseline samples:
|
cartermckinnon
force-pushed
the
cache-kubelet-version
branch
from
3051064
to
fa74981
Compare
|
Added /ci |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
|
Some samples using
|
|
Definitely a major improvement:
|
cartermckinnon
force-pushed
the
cache-kubelet-version
branch
from
fa74981
to
1189c47
Compare
cartermckinnon
force-pushed
the
cache-kubelet-version
branch
from
1189c47
to
450d096
Compare
cartermckinnon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Improves #1751.
Description of changes:
This PR aims to reduce
nodeadm-configtime by determining thekubeletversion using a text file created during the AMI build process, instead of executingkubelet --version.Using
kubelet --versioninvolves EBS lazy-loading time plus the overhead of the child process, and doing this duringnodeadm-configdelays execution of the user's user data scripts andnodeadm-run.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.