Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kn: checksum bindings #121

Open
wants to merge 10 commits into
base: kn-main
Choose a base branch
from
Open

kn: checksum bindings #121

wants to merge 10 commits into from
+128 −7

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Nov 18, 2024 •
edited
Loading

Description of changes:

  • Add MD5 implementation
  • Add WithCrt mixin class used to ensure CRT.initRuntime { } is called
    • Trying to use these CRT hash functions from smithy-kotlin would result in errors because CRT was not properly initialized
  • Fix an IndexOutOfBounds bug caused by passing empty inputs to hash functions

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lauzadis lauzadis marked this pull request as ready for review November 18, 2024 20:24
@lauzadis lauzadis requested a review from a team as a code owner November 18, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lauzadis