Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update agent example to support apple silicon #89

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update agent example to support apple silicon #89

wants to merge 2 commits into from

Conversation

miguelcss
Copy link

@miguelcss miguelcss commented Nov 23, 2021 •
edited
Loading

Description of changes:

Update agent example to support apple silicon

Removed hardcoded cloudwatch-agent debian S3 file, and replaced with docker-image that supports several platforms

Testing:

Env

% sw_vers
ProductName:	macOS
ProductVersion:	12.0.1
BuildVersion:	21A559

./bin/start-agent.sh

Saw metrics being published from docker container:

2021-11-23T17:12:08Z D! [outputs.cloudwatchlogs] Wrote batch of 1 metrics in 10.4255ms
2021-11-23T17:12:08Z D! [outputs.cloudwatchlogs] Buffer fullness: 0 / 10000 metrics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

miguelcss
miguelcss commented Nov 23, 2021
View reviewed changes
bin/start-agent.sh
@@ -29,7 +29,7 @@ region = $AWS_REGION
" > ./.aws/config

docker build -t agent:latest .
docker run -p 25888:25888/udp -p 25888:25888/tcp \
docker run -p 25888:25888/udp -p 25888:25888/tcp \
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removed extra space

miguelcss
miguelcss commented Nov 23, 2021
View reviewed changes
src/integration-test/resources/agent/Dockerfile
ENTRYPOINT ["/opt/aws/amazon-cloudwatch-agent/bin/start-amazon-cloudwatch-agent"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just added new line at EOF

@miguelcss
Copy link
Author

Any feedback on this?

@miguelcss
Copy link
Author

Ping

@miguelcss
Copy link
Author

Ping, anyone at aws-embedded-metrics-java project with admin permissions can have a look at this PR?
Some more coming up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miguelcss