Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DC abort logic for Secure Element #459

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix DC abort logic for Secure Element #459

merged 1 commit into from
Jul 10, 2024

Conversation

asconcepcion
Copy link
Contributor

@asconcepcion asconcepcion commented Jun 19, 2024 •
edited
Loading

If Secure Element is compiled into binary and enabled via configuration it shouldn't abort.

Motivation

  • Currently it is not possible to enable Secure Element due to bug in the abort logic that checks if the feature is compiled into the binary and enabled via configuration.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fix DC abort logic for Secure Element
fbdf79b 
If Secure Element is compiled into binary and enabled via configuration
it shouldn't abort.
@HarshGandhi-AWS HarshGandhi-AWS self-requested a review July 8, 2024 18:03
@HarshGandhi-AWS HarshGandhi-AWS merged commit cf738c8 into awslabs:main Jul 10, 2024
23 of 50 checks passed
@asconcepcion asconcepcion deleted the bugFix/secure-element-abort-logic branch July 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshGandhi-AWS HarshGandhi-AWS HarshGandhi-AWS approved these changes

@RogerZhongAWS RogerZhongAWS RogerZhongAWS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asconcepcion @HarshGandhi-AWS @RogerZhongAWS