Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: profile credentials provider needing opt in to internal annotation #1215

Merged
merged 4 commits into from
Feb 16, 2024
Merged

fix: profile credentials provider needing opt in to internal annotation #1215

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89a6e40
Remove InternalSdkApi annotation
0marperez Feb 12, 2024
dbb15cf
Changelog
0marperez Feb 12, 2024
164ef76
Change dependency from implementation to api
0marperez Feb 13, 2024
db3d20c
Left AwsConfigurationSource as internal
0marperez Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/a3dbe57d-1309-4535-8025-6458466ba154.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "a3dbe57d-1309-4535-8025-6458466ba154",
"type": "bugfix",
"description": "Profile credentials provider is no longer marked as internal API",
"issues": [
"awslabs/aws-sdk-kotlin#1208"
]
}
1 change: 0 additions & 1 deletion aws-runtime/aws-config/common/src/aws/sdk/kotlin/runtime/config/profile/AwsConfigLoader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ private fun mergeSectionMaps(maps: List<SectionMap>): SectionMap = buildMap {
/**
* Specifies the active profile and configured (may not actually exist) locations of configuration files.
*/
@InternalSdkApi
public data class AwsConfigurationSource(val profile: String, val configPath: String, val credentialsPath: String)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: I believe we still want this type to be @InternalSdkApi. I think instead we should add to ProfileCredentialsProvider a new constructor overload that doesn't have an AwsConfigurationSource parameter. Then we can mark the current constructor as @InternalSdkApi.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about if the user wants to configure the AwsConfigurationSource?


/**
Expand Down
Loading