Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: track artifact sizes #1230

Closed
wants to merge 7 commits into from
Closed

chore: track artifact sizes #1230

wants to merge 7 commits into from

Conversation

aajtodd
Copy link
Collaborator

@aajtodd aajtodd commented Feb 21, 2024

Issue #

#416

Description of changes

  • Adds a new task to gather the JVM jar sizes and write them to a JSON file in the format expected by CloudWatch.
  • Adds a new task to compare the current sizes to historical data in CW
  • Adds a new GH workflow to publish the results of the comparison to the PR.
    • On release the artifact sizes will be updated and new data pushed to CW

TODO

  • Still need to test this in PR
  • The workflow should probably fail if we are x % delta above prior averages (or whatever threshold we want to define)
  • Manual workflow dispatch would be nice

Questions

  • Is this the "right" way? Should we just use GetMetricData and compute average from that
  • This doesn't handle any of smithy-kotlin runtime directly but it does by computing the dependency closure size of a few services.
  • The dependency closure includes everything needed at runtime (stdlib, smithy-kotlin, aws-runtime + the service JAR size). Is that what we want to track?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner February 21, 2024 21:41
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

MetricName Dimensions Bytes DeltaPct
ArtifactSize Artifact=aws-config-jvm.jar 1,100,080 +0.00%
ArtifactSize Artifact=aws-core-jvm.jar 7,533 +0.00%
ArtifactSize Artifact=aws-endpoint-jvm.jar 10,801 +0.00%
ArtifactSize Artifact=aws-http-jvm.jar 65,781 +0.00%
ArtifactSize Artifact=s3-jvm.jar 5,072,345 +0.00%
DependencyClosureSize KmpTarget=jvm,Service=s3 13,279,073 +0.00%

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@lauzadis
Copy link
Member

lauzadis commented May 6, 2024

Implemented in #1290

@lauzadis lauzadis closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants