-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to Gradle 8 #1829
Draft
jbelkins
wants to merge
13
commits into
main
Choose a base branch
from
jbe/gradle_8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ae17a70
chore: Update to Gradle 8
jbelkins 150d64c
Empty
jbelkins cde5467
Fix jacoco test report task
jbelkins 9ec5319
Merge branch 'main' into jbe/gradle_8
jbelkins ef7f683
Merge branch 'main' into jbe/gradle_8
jbelkins c976f75
Merge branch 'main' into jbe/gradle_8
jbelkins 9c70a60
Merge branch 'main' into jbe/gradle_8
jbelkins b80793a
Merge branch 'main' into jbe/gradle_8
jbelkins 934dba2
Update to smithy-gradle 1.2.0
jbelkins 1eb2c23
Merge remote-tracking branch 'origin/main' into jbe/gradle_8
jbelkins 1a19324
Merge branch 'jbe/gradle_8' of github.com:awslabs/aws-sdk-swift into …
jbelkins 4327e37
Merge branch 'main' into jbe/gradle_8
jbelkins a9af1cb
Merge remote-tracking branch 'origin/main' into jbe/gradle_8
jbelkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,12 +77,13 @@ tasks.test { | |
|
||
// Configure jacoco (code coverage) to generate an HTML report | ||
tasks.jacocoTestReport { | ||
dependsOn(tasks.test) | ||
reports { | ||
xml.isEnabled = false | ||
csv.isEnabled = false | ||
html.destination = file("$buildDir/reports/jacoco") | ||
xml.required.set(false) | ||
csv.required.set(false) | ||
html.outputLocation.set(file("$buildDir/reports/jacoco")) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test report config updated & taken from smithy project |
||
} | ||
} | ||
|
||
// Always run the jacoco test report after testing. | ||
tasks["test"].finalizedBy(tasks["jacocoTestReport"]) | ||
tasks["test"].finalizedBy(tasks.jacocoTestReport) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Autogenerated change |
||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gradle 8 changes the name of this property