Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for user engagement event #34

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add configuration for user engagement event

How did you test these changes?
Added test case for close _user_engagement event and assert will not record this event.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Aug 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40% 🎉

Comparison is base (18ee39b) 86.17% compared to head (936de6a) 86.57%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #34      +/-   ##
============================================
+ Coverage     86.17%   86.57%   +0.40%     
- Complexity      388      392       +4     
============================================
  Files            39       39              
  Lines          1410     1415       +5     
  Branches        126      125       -1     
============================================
+ Hits           1215     1225      +10     
+ Misses          120      116       -4     
+ Partials         75       74       -1     
Files Changed Coverage Δ
...aws/solution/clickstream/AWSClickstreamPlugin.java 83.52% <ø> (+2.63%) ⬆️
...clickstream/AWSClickstreamPluginConfiguration.java 100.00% <100.00%> (+4.87%) ⬆️
...olution/clickstream/ClickstreamManagerFactory.java 100.00% <100.00%> (ø)
...tion/clickstream/client/AutoRecordEventClient.java 100.00% <100.00%> (ø)
...n/clickstream/client/ClickstreamConfiguration.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit d810af5 into main Aug 24, 2023
3 checks passed
@zxkane zxkane deleted the feature_configure_user_engagement branch August 24, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants