Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset event app end #35

Merged
merged 1 commit into from
Aug 25, 2023
Merged

feat: add preset event app end #35

merged 1 commit into from
Aug 25, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add preset event app end

How did you test these changes?
Added test case for _app_end event.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the documentation Improvements or additions to documentation label Aug 25, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 94.59% and project coverage change: +0.55% 🎉

Comparison is base (48157d9) 86.04% compared to head (3044145) 86.59%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #35      +/-   ##
============================================
+ Coverage     86.04%   86.59%   +0.55%     
- Complexity      378      393      +15     
============================================
  Files            39       39              
  Lines          1383     1425      +42     
  Branches        121      125       +4     
============================================
+ Hits           1190     1234      +44     
+ Misses          122      116       -6     
- Partials         71       75       +4     
Files Changed Coverage Δ
...aws/solution/clickstream/AWSClickstreamPlugin.java 83.52% <ø> (+2.63%) ⬆️
...oftware/aws/solution/clickstream/client/Event.java 100.00% <ø> (ø)
...solution/clickstream/client/ScreenRefererTool.java 84.21% <62.50%> (-15.79%) ⬇️
...ution/clickstream/client/util/PreferencesUtil.java 92.77% <66.66%> (+2.52%) ⬆️
...clickstream/AWSClickstreamPluginConfiguration.java 100.00% <100.00%> (+4.87%) ⬆️
...solution/clickstream/ActivityLifecycleManager.java 97.91% <100.00%> (+0.41%) ⬆️
...olution/clickstream/ClickstreamManagerFactory.java 100.00% <100.00%> (ø)
...tion/clickstream/client/AutoRecordEventClient.java 99.09% <100.00%> (-0.91%) ⬇️
...n/clickstream/client/ClickstreamConfiguration.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit c808543 into main Aug 25, 2023
3 checks passed
@zxkane zxkane deleted the feature_app_end branch August 25, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants