Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add session attributes in _first_open event #47

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add session attributes in _first_open event

How did you test these changes?
test by asset session related attributes in the _first_open event.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f74a4c9) 87.00% compared to head (1340021) 86.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #47      +/-   ##
============================================
- Coverage     87.00%   86.95%   -0.05%     
+ Complexity      420      419       -1     
============================================
  Files            40       40              
  Lines          1485     1487       +2     
  Branches        129      129              
============================================
+ Hits           1292     1293       +1     
  Misses          121      121              
- Partials         72       73       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 7c7e3e6 into main Dec 7, 2023
4 checks passed
@zxkane zxkane deleted the add_session_attributes_to_first_open branch December 7, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants