Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preset traffic source attributes #78

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat: add preset traffic source attributes #78

merged 3 commits into from
Apr 10, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

@zhu-xiaowei zhu-xiaowei commented Apr 10, 2024

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add preset traffic source attributes
  2. add _app_install_channel, event _value and _currency preset attributes

How did you test these changes?
added test case for traffic source attributes

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Apr 10, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane April 10, 2024 09:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (cd37cc4) to head (9229b04).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #78   +/-   ##
=========================================
  Coverage     87.93%   87.93%           
  Complexity      488      488           
=========================================
  Files            40       40           
  Lines          1716     1716           
  Branches        171      171           
=========================================
  Hits           1509     1509           
  Misses          140      140           
  Partials         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit d0f6d2b into main Apr 10, 2024
6 checks passed
@zxkane zxkane deleted the traffic_source branch April 10, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants