Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add items key for objc #45

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: add items key for objc #45

merged 1 commit into from
Dec 18, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add ClickstreamItemKey for Objective-C API

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Dec 18, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane December 18, 2023 06:43
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (648f658) 95.50% compared to head (f3dd659) 95.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          35       35           
  Lines        1937     1937           
=======================================
  Hits         1850     1850           
  Misses         87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 1c1cc20 into main Dec 18, 2023
4 checks passed
@zxkane zxkane deleted the add_item_key_for_objc branch December 18, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants