Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Apache pinot support #353

Merged
merged 21 commits into from
Dec 22, 2023
Merged

feat: Adding Apache pinot support #353

merged 21 commits into from
Dec 22, 2023

Conversation

wahab-io
Copy link
Contributor

@wahab-io wahab-io commented Oct 20, 2023 •
edited
Loading

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

This is a work in progress for adding support for Apache Pinot. Functionality is complete, need time to write the blueprint documentation. Creating the PR to review terraform code.
Closes: #76

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@wahab-io wahab-io temporarily deployed to DoEKS Test October 20, 2023 02:06 — with GitHub Actions Inactive
@wahab-io wahab-io changed the title Apache pinot feat: Adding Apache pinot support Oct 20, 2023
@wahab-io wahab-io temporarily deployed to DoEKS Test October 24, 2023 10:16 — with GitHub Actions Inactive
@wahab-io wahab-io temporarily deployed to DoEKS Test October 25, 2023 19:05 — with GitHub Actions Inactive
@wahab-io wahab-io temporarily deployed to DoEKS Test October 25, 2023 19:13 — with GitHub Actions Inactive
@wahab-io wahab-io temporarily deployed to DoEKS Test October 25, 2023 19:36 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 26, 2023
@vara-bonthu vara-bonthu removed the stale label Nov 28, 2023
vara-bonthu
vara-bonthu reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wahab-io 👍🏼 I left few minor comments

distributed-databases/pinot/addons.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/addons.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/data.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/locals.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/variables.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/variables.tf Show resolved Hide resolved
vara-bonthu
vara-bonthu reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

distributed-databases/pinot/main.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/main.tf Show resolved Hide resolved
distributed-databases/pinot/addons.tf Show resolved Hide resolved
distributed-databases/pinot/addons.tf Outdated Show resolved Hide resolved
distributed-databases/pinot/addons.tf Outdated Show resolved Hide resolved
vara-bonthu
vara-bonthu approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@vara-bonthu vara-bonthu merged commit 161339e into awslabs:main Dec 22, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Apache Pinot on Amazon EKS
2 participants
@wahab-io @vara-bonthu