Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add codespell config, pre-commit and dedicated workflow (to catch new typos) and get typos fixed #385

Merged
merged 6 commits into from
Dec 13, 2023

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented Dec 8, 2023

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.

sorry, too late... ;) Let's discuss directly in this PR

https://github.com/codespell-project/codespell is robust and great way to ensure your codebase is typos free. Surprisingly there were not that many false positives/workarounds needed here.

Motivation

Make a world a better typo free place.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally. : I only ran codespell one there, since I do not have terraform locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@vara-bonthu
Copy link
Collaborator

Tagging the PR to the existing issue #176

Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🔥 LGTM 👍🏼

@yarikoptic
Copy link
Contributor Author

thank you for the thank you!

@vara-bonthu vara-bonthu changed the title Add codespell config, pre-commit and dedicated workflow (to catch new typos) and get typos fixed feat: Add codespell config, pre-commit and dedicated workflow (to catch new typos) and get typos fixed Dec 10, 2023
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@askulkarni2 askulkarni2 merged commit 30ad93b into awslabs:main Dec 13, 2023
43 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants