feat: Spark-operator update karpenter to v1 #673
Conversation
| @@ -103,7 +103,7 @@ module "eks_blueprints_addons" { | |||
| } | |||
| } | |||
| karpenter = { | |||
| chart_version = "0.37.0" | |||
| chart_version = "1.0.0" | |||
There was a problem hiding this comment.
You might need to uplift data addons tag and update the Karpenter resources to v1.
There was a problem hiding this comment.
good call. I was pulling v1.34.0 but we should set that as the min.
When i rolled this out the existing karpenter resource configs seemed to get created as v1 but i'm still working through the configs to see if they need updates to the spec.
| @@ -3,7 +3,7 @@ | |||
| #--------------------------------------------------------------- | |||
| module "eks_data_addons" { | |||
| source = "aws-ia/eks-data-addons/aws" | |||
| version = "~> 1.30" # ensure to update this to the latest/desired version | |||
| version = "~> 1.34" # ensure to update this to the latest/desired version | |||
There was a problem hiding this comment.
please use a fixed version instead, in this case it should be 1.34.0 ... we just had a problem because of the ~> config
There was a problem hiding this comment.
I think I was able to merge all the upstream changes and keep the versions you mention here (Addons 1.34.0 and karpenter 1.0.6).
| @@ -417,7 +417,7 @@ module "eks_blueprints_addons" { | |||
| } | |||
| } | |||
| karpenter = { | |||
| chart_version = "v0.34.0" | |||
| chart_version = "1.0.0" | |||
There was a problem hiding this comment.
please use the latest version 1.0.6
There was a problem hiding this comment.
I think I was able to merge all the upstream changes and keep the versions you mention here (Addons 1.34.0 and karpenter 1.0.6).
alanty
changed the title
|
Closing this one out, the upgrade got handled in #683 |
What does this PR do?
updates the charts/configs for karpenter v1 in the spark-operator blueprint.
the karpenter resources have already been bumped, this moves the helm chart to 1.0.0 (latest).
Motivation
#669 came up when i was creating a copy of the solution today.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators