fix: Trino scale-down to zero with KEDA #726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments
ratnopamc
requested changes
Jan 16, 2025
Comment on lines
-28
to
-29
| repository_username = data.aws_ecrpublic_authorization_token.token.user_name | ||
| repository_password = data.aws_ecrpublic_authorization_token.token.password |
There was a problem hiding this comment.
Any specific reason for omitting this? This would result in 403 while accessing karpenter helm_chart.
| ``` | ||
|
|
||
| Now, lets access the Trino UI by pasting above Load Balancer DNS in a web browser and login with username `admin` in the login window as shown below: | ||
| Now, lets access the Trino UI at `http://localhost:8080` through web browser and login with username `admin` in the login window as shown below: | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
Please replace the Trino UI screenshot with "0" Active Workers to match the initial 0 active worker configuration above.
|
|
||
|  | ||
|
|
||
| We can see Trino Web UI showing 3 active workers | ||
| Example of Trino Web UI showing 3 active workers: |
| name = "karpenter" | ||
| repository = "oci://public.ecr.aws/karpenter" | ||
| chart = "karpenter" | ||
| version = "1.0.6" |
There was a problem hiding this comment.
Can we also update to the latest Karpenter version 1.1.1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Changed KEDA scaled object to improve handling of scaling to zero. Adjusted doc accordingly.
Motivation
The current KEDA scaled object for Trino interrupts active query to scale down. The Trino coordinator often gets evicted when Karpenter replacing node with smaller instance as result of scaling down.
More
website/docsorwebsite/blogsection for this featurepre-commit run -awith this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes