#169: Improve ApproxQuantile metrics instance description

awslabs · Nov 14, 2019 · 0436d5a · 0436d5a
1 parent c7b906d
commit 0436d5a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/main/scala/com/amazon/deequ/analyzers/ApproxQuantile.scala b/src/main/scala/com/amazon/deequ/analyzers/ApproxQuantile.scala
@@ -87,14 +87,14 @@ case class ApproxQuantile(column: String, quantile: Double, relativeError: Doubl
     state match {
       case Some(theState) =>
         val percentile = theState.percentileDigest.getPercentiles(Array(quantile)).head
-        Analyzers.metricFromValue(percentile, "ApproxQuantile", column)
+        Analyzers.metricFromValue(percentile, s"ApproxQuantile-$quantile", column)
       case _ =>
-        Analyzers.metricFromEmpty(this, "ApproxQuantile", column)
+        Analyzers.metricFromEmpty(this, s"ApproxQuantile-$quantile", column)
     }
   }
 
   override def toFailureMetric(exception: Exception): DoubleMetric = {
-    Analyzers.metricFromFailure(exception, "ApproxQuantile", column)
+    Analyzers.metricFromFailure(exception, s"ApproxQuantile-$quantile", column)
   }
 
   override def preconditions: Seq[StructType => Unit] = {

diff --git a/src/main/scala/com/amazon/deequ/metrics/Metric.scala b/src/main/scala/com/amazon/deequ/metrics/Metric.scala
@@ -58,11 +58,11 @@ case class KeyedDoubleMetric(
   override def flatten(): Seq[DoubleMetric] = {
     if (value.isSuccess) {
       value.get.map { case (key, correspondingValue) =>
-        DoubleMetric(entity, s"name-$key", instance, Success(correspondingValue))
+        DoubleMetric(entity, s"$name-$key", instance, Success(correspondingValue))
       }
       .toSeq
     } else {
-      Seq(DoubleMetric(entity, s"name", instance, Failure(value.failed.get)))
+      Seq(DoubleMetric(entity, s"$name", instance, Failure(value.failed.get)))
     }
   }
 }
diff --git a/src/test/scala/com/amazon/deequ/analyzers/AnalysisTest.scala b/src/test/scala/com/amazon/deequ/analyzers/AnalysisTest.scala
@@ -92,7 +92,7 @@ class AnalysisTest extends WordSpec with Matchers with SparkContextSpec with Fix
         Success(6.0)))
       resultMetrics should contain(DoubleMetric(Entity.Column, "CountDistinct", "att1",
         Success(6.0)))
-      resultMetrics should contain(DoubleMetric(Entity.Column, "ApproxQuantile", "att1",
+      resultMetrics should contain(DoubleMetric(Entity.Column, "ApproxQuantile-0.5", "att1",
         Success(3.0)))
     }