Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement uuid.MAX, uuid.v1ToV6(), uuid.V6(), uuid.v6ToV1(), uuid.V7() #524

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

kevinmingtarja
Copy link
Contributor

@kevinmingtarja kevinmingtarja commented Aug 4, 2024

Issue

Closes #485

Description of changes

Implement the following methods on the llrt:uuid package:

  • uuid.MAX
  • uuid.v1ToV6()
  • uuid.V6()
  • uuid.v6ToV1()
  • uuid.V7()

The goal is to achieve greater compatibility with the existing Node.js package: https://github.com/uuidjs/uuid

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM! 👏

@richarddavison richarddavison merged commit fbea672 into awslabs:main Aug 4, 2024
8 checks passed
@kevinmingtarja kevinmingtarja deleted the uuid-compat branch August 5, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

further advances in uuid compatibility
2 participants