London Equation bugfix #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughcars
force-pushed
the
hughcars/london-equation-bugfix
branch
from
f2298c3 to
e67c73b
Compare
… rather than mass term
…date documentation.
hughcars
force-pushed
the
hughcars/london-equation-bugfix
branch
from
e67c73b to
e9b1afd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The London equation implementation has an issue where the london depth is added as a curlcurl term, where it should have been added as a mass term. This was due to a typo where
dfwas used instead off. The effect of the London equation is to make a reaction-diffusion (second order) boundary layer in the London region, which is independent of driving frequency, hence needing the mass term. The magnetic boundary layer effect was confirmed after this fix.Additionally to get good results requires disabling the divergence free cleaner, as the mass term results in a change to the nullspace of the stiffness matrix.
