-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Avoid impersonation #202
base: master
Are you sure you want to change the base?
Feature: Avoid impersonation #202
Conversation
I've just noticed that my editor seems to have made some unnecessary whitespace changes, I'll try to revert those. |
5015650
to
7eef69c
Compare
Thanks, this feature looks nice. I was hoping to avoid domain-wide delegation, and impersonating a real Google account. You could leave Similarly (I'm not sure if there's any real advantage to an impersonated user, it seems worse to me. But supporting both may allow easier migration between them? Switching over entirely to non-impersonated seems better to me, but is a bigger breaking change.) Because the Google docs aren't too clear on this, it's probably worth adding a note to the README to point specifically to the "Assign a role to a service account" docs section and explain how to set up the service account:
|
…void-impersonation/full-stack
…void-impersonation/full-stack
Issue #, if available:
#192
Description of changes:
Replaces
--google-admin
(and associated environment variables, template options) with--customer-id
, while incorporating @behobu's changes from #192. This allows the app to function without needing to impersonate an Google Workspace admin user.I'm not as confident in the CF/SAM changes as I am in the code changes; if desired, I have an alternative branch I can recreate the PR using, which only changes the app code, and which would allow you to handle the templates as you see fit.
Also note that as-implemented, the code currently replaces the
--google-admin
option with the--customer-id
option. For my own purposes, this was acceptable, even desirable, but if retaining the option to do user impersonation is desirable it probably wouldn't be too hard to adjust things so you can pass either option (though not both).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.