feat: add solana ampd implementation #744
Open
+4,804
−489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Solana account parsing tools.
* Add solana verification functionality * Add unit tests to Solana message verifier * Refactor * Solana msg verifier reshape (#4) * remove comment * Use Solana types from Solana crates We were using hand crafted Solana types for interacting with RPC. * refactor: make clippy happy * Add some traces to Solana msg verifier * Remove outdated todos * refactor: re-use already calculated variable * Clarify test code usage * Solana msg verifier, try till one program log matches gw event * Add note to axelar to review when in PR * fail if tx_id is not found in signatures * Always fail on chain at handler level * Handle errors in case a tx cannot be found (finish the handler) * Remove commented code * Use original type from solana-axelar repo * Ensure that we verify sender address in sol msg verifier * Do not panic on PartialEq * refactor: clippy * remove no longer used code * Add more tests definition to solana msg verify iteration logic --------- Co-authored-by: eloylp <[email protected]>
Were only intended during development to understand the API.
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Co-authored-by: tilacog <[email protected]>
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
Signed-off-by: Guilherme Felipe da Silva <[email protected]>
It will be managed later. This prepares this branch for merge with upstream.
bugfix on event parsing
cjcobb23
reviewed
Jan 30, 2025
Comment on lines
+139
to
+140
| let poll_id_str: String = poll_id.into(); | ||
| let source_chain_str: String = source_chain.into(); |
There was a problem hiding this comment.
might be cleaner to just do this inline
Comment on lines
+120
to
+121
| }; | ||
| if !participants.contains(&self.verifier) { |
There was a problem hiding this comment.
Suggested change
| }; | |
| if !participants.contains(&self.verifier) { | |
| }; | |
| if !participants.contains(&self.verifier) { |
Comment on lines
+19
to
+30
| GatewayEvent::CallContract(event) => ( | ||
| &event.sender_key, | ||
| &event.payload_hash, | ||
| &event.destination_chain, | ||
| &event.destination_contract_address, | ||
| ), | ||
| GatewayEvent::CallContractOffchainData(event) => ( | ||
| &event.sender_key, | ||
| &event.payload_hash, | ||
| &event.destination_chain, | ||
| &event.destination_contract_address, | ||
| ), |
There was a problem hiding this comment.
might want to add some comments here about why there are two events
| } | ||
| }; | ||
|
|
||
| // pare the events |
There was a problem hiding this comment.
Suggested change
| // pare the events | |
| // compare the events |
| where | ||
| F: Fn(&GatewayEvent) -> bool, | ||
| { | ||
| // the event idx cannot be larger than usize |
There was a problem hiding this comment.
why? also we might want to fail earlier in this case, there's no point to even make the RPC call
| if !participants.contains(&self.verifier) { | ||
| return Ok(vec![]); | ||
| } | ||
|
|
There was a problem hiding this comment.
should check the source chain
| if !participants.contains(&self.verifier) { | ||
| return Ok(vec![]); | ||
| } | ||
|
|
There was a problem hiding this comment.
should check the source chain
| @@ -69,7 +69,7 @@ impl PartialEq<ContractEventBody> for VerifierSetConfirmation { | |||
| } | |||
| } | |||
|
|
|||
| pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote { | |||
| pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote { | |||
There was a problem hiding this comment.
Suggested change
| pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote { | |
| pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote { |
Comment on lines
+44
to
+53
| AddressFormat::Base58Solana => { | ||
| const SOLANA_PUBKEY_LEN: usize = 32; | ||
|
|
||
| let pubkey_vec = bs58::decode(address) | ||
| .into_vec() | ||
| .change_context(Error::InvalidAddress(address.to_string()))?; | ||
| if pubkey_vec.len() != SOLANA_PUBKEY_LEN { | ||
| bail!(Error::InvalidAddress(address.to_string())) | ||
| } | ||
| } |
There was a problem hiding this comment.
where is this being used?
| cosmwasm_contract = "axelar1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqecnww6" | ||
| chain_name = "solana" | ||
| chain_rpc_url = "https://api.devnet.solana.com" | ||
| max_tx_cache_entries = 6 |
There was a problem hiding this comment.
Is this correct? Where is this handled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Eiger, we are implementing the integration between Axelar and Solana.
This PR introduces the necessary logic for the ampd component, including:
Both verifier components share the same Solana transaction fetch and log parsing logic, which facilitates identifying event sequences within Solana programs execution outputs.
Todos
Steps to Test
ampdwith an updatedampd.tomlfile, pointing to a localtofndsetup.tofndmust be up and running.ampddaemon.Expected Behaviour
It should forward GMP messages from one chain to the another, passing them through the axelar devnet network.
Other Notes
Manual testing is missing because we are waiting for Axelar contract approval.