Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interchain-token-service): update error handling for token id config #121

Merged
merged 5 commits into from
Dec 18, 2024
Merged

fix(interchain-token-service): update error handling for token id config #121

merged 5 commits into from
Dec 18, 2024

Conversation

ahramy
Copy link
Contributor

@ahramy ahramy commented Dec 17, 2024 •
edited by jira bot
Loading

@ahramy ahramy marked this pull request as ready for review December 17, 2024 06:57
@ahramy ahramy requested a review from a team as a code owner December 17, 2024 06:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (6ec2622) to head (d4e13c2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   94.46%   94.44%   -0.03%     
==========================================
  Files          52       52              
  Lines        3019     3023       +4     
==========================================
+ Hits         2852     2855       +3     
- Misses        167      168       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

milapsheth
milapsheth approved these changes Dec 17, 2024
View reviewed changes
contracts/interchain-token-service/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/contract.rs Outdated Show resolved Hide resolved
@ahramy ahramy enabled auto-merge (squash) December 18, 2024 04:21
@ahramy ahramy merged commit 8430b93 into main Dec 18, 2024
5 checks passed
@ahramy ahramy deleted the fix/update-error-handling-for-token-address branch December 18, 2024 04:23
@talalashraf talalashraf mentioned this pull request Jan 17, 2025
Merged
@ahramy ahramy mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttissNgo AttissNgo AttissNgo approved these changes

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahramy @codecov-commenter @milapsheth @AttissNgo