Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(axelar-std-derive): add status support to contractstorage macro #234

Merged
merged 12 commits into from
Jan 31, 2025
Merged

feat(axelar-std-derive): add status support to contractstorage macro #234

merged 12 commits into from
Jan 31, 2025

Conversation

nbayindirli
Copy link
Contributor

@nbayindirli nbayindirli requested a review from a team as a code owner January 31, 2025 00:58
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (94632d8) to head (9eca93d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   97.09%   97.15%   +0.05%     
==========================================
  Files          69       69              
  Lines        3923     4000      +77     
==========================================
+ Hits         3809     3886      +77     
  Misses        114      114

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbayindirli nbayindirli mentioned this pull request Jan 31, 2025
Merged
@nbayindirli nbayindirli enabled auto-merge (squash) January 31, 2025 22:22
@nbayindirli nbayindirli merged commit 4ffb0cb into main Jan 31, 2025
5 checks passed
@nbayindirli nbayindirli deleted the feat/status-value branch January 31, 2025 22:25
milapsheth
milapsheth reviewed Feb 1, 2025
View reviewed changes
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/testdata/storage_schema_generation_succeeds.golden Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs
quote! {
#[doc = " Value Type Getter"]
pub fn #getter_name(#param_list) -> Option<#value_type> {
let key = #key;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use #key directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this response above

packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
packages/stellar-axelar-std-derive/src/storage.rs Show resolved Hide resolved
@talalashraf talalashraf mentioned this pull request Feb 4, 2025
Closed
@cgorenflo cgorenflo mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth left review comments

@cgorenflo cgorenflo cgorenflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbayindirli @milapsheth @cgorenflo