refactor: move shared interfaces in preparation of ownership trait extraction #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 89.27% 89.27%
=======================================
Files 43 43
Lines 2900 2900
=======================================
Hits 2589 2589
Misses 311 311 ☔ View full report in Codecov by Sentry. |
milapsheth
approved these changes
Dec 4, 2024
…p-extraction # Conflicts: # packages/axelar-soroban-std/src/contract_traits/testdata/test_format_last_emitted_event.golden # packages/axelar-soroban-std/src/contract_traits/upgradable.rs # packages/axelar-soroban-std/src/lib.rs
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the shared_interfaces.rs into the contract_traits folder and renames it to upgradable.rs. Subsequently, the import paths in dependent files needed to be updated. No changes to the logic occurred.
AXE-6810