This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
cmd: allow file descriptor limit to be set via CLI (#24477) #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eth, cmd: allow FdLimit to be set in config/command line (#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]>
huyngopt1994
approved these changes
Jan 31, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…nity#400) * eth, cmd: allow FdLimit to be set in config/command line (#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs ----- Currently, we set the OpenFilesCacheCapacity leveldb's option to system fd limit / 2 ``` // OpenFilesCacheCapacity defines the capacity of the open files caching. OpenFilesCacheCapacity int ``` This can be the reason for high memory in page cache (high active_file in /sys/fs/cgroup/memory/memory.stat). We cherry-pick this commit to allow setting fdlimit through CLI to reduce the cache capacity in leveldb. Co-authored-by: Olivier H <[email protected]> Co-authored-by: Gary Rong <[email protected]> Co-authored-by: Péter Szilágyi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth, cmd: allow FdLimit to be set in config/command line (#24148)
eth/ethconfig: format code
cmd, eth/ethconfig: simplify fdlimit arg, disallow toml
cnd/utils: make fdlimit setting nicer on the logs
Currently, we set the OpenFilesCacheCapacity leveldb's option to system fd limit / 2
This can be the reason for high memory in page cache (high active_file in /sys/fs/cgroup/memory/memory.stat). We cherry-pick this commit to allow setting fdlimit through CLI to reduce the cache capacity in leveldb.