This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
consortium-v2: fix the system transaction's sender check in ApplyTransaction #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andicrypt
approved these changes
Feb 20, 2024
Following EIP-3607 ("Reject transactions from senders with deployed code"), if
the sender of transaction has deployed code (not an EOA), the transaction is
rejected. This commit adds the same check to system transaction.
…coinbase Currently, the system transaction's sender check looks weird, it still allows that sender is different from coinbase. However, the sender is checked to be equal to coinbase in IsSystemMessage already, so there must be no issue here. This commit fixes that check in ApplyTransaction, we keep this check to make it more explicit though the check is redundant.
minh-bq
force-pushed
the
fix/eoa-check-system-tx
branch
from
4970e78 to
4539c1a
Compare
huyngopt1994
approved these changes
Feb 26, 2024
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…saction (axieinfinity#405) * consortium-v2: check that sender of system transaction is EOA Following EIP-3607 ("Reject transactions from senders with deployed code"), if the sender of transaction has deployed code (not an EOA), the transaction is rejected. This commit adds the same check to system transaction. * consortium-v2: cleanup the check of system transaction's sender with coinbase Currently, the system transaction's sender check looks weird, it still allows that sender is different from coinbase. However, the sender is checked to be equal to coinbase in IsSystemMessage already, so there must be no issue here. This commit fixes that check in ApplyTransaction, we keep this check to make it more explicit though the check is redundant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following EIP-3607 ("Reject transactions from senders with deployed code"), if
the sender of transaction has deployed code (not an EOA), the transaction is
rejected. This commit adds the same check to system transaction.
Currently, the system transaction's sender check looks weird, it still allows
that sender is different from coinbase. However, the sender is checked to be
equal to coinbase in IsSystemMessage already, so there must be no issue here.
This commit fixes that check in ApplyTransaction, we keep this check to make it
more explicit though the check is redundant.