This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
consortium-v2: new RLP encoder/decoder for HeaderExtraData #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5381b39
to
b30a69b
Compare
895dd5b
to
0ec2859
Compare
df24f03
to
7e5a642
Compare
7e5a642
to
00c57bb
Compare
e53a5f6
to
7e6f822
Compare
minh-bq
reviewed
Mar 19, 2024
Benchmark the length of encoded data (in bytes) in setting of 22 validators. The data is evaluated in term of the length of bytes.
|
Note: the smaller is better.
Benchmark the decoding performance, take performance average of 100k times of executions:
|
7e6f822
to
fb5c83e
Compare
2bb1d37
to
13f9be0
Compare
minh-bq
approved these changes
Mar 20, 2024
minh-bq
added a commit
that referenced
this pull request
Apr 22, 2024
* consortium-v2: implement RLP encoding for header extra data * consortium-v2: integrate new RLP encoder/decoder for header extra data * consortium-v2: optimize extra data rlp encoding * consortium-v2: benchmark for new rlp encoding * consortium-v2: clean up unit test --------- Co-authored-by: Bui Quang Minh <[email protected]>
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
* consortium-v2: implement RLP encoding for header extra data * consortium-v2: integrate new RLP encoder/decoder for header extra data * consortium-v2: optimize extra data rlp encoding * consortium-v2: benchmark for new rlp encoding * consortium-v2: clean up unit test --------- Co-authored-by: Bui Quang Minh <[email protected]>
minh-bq
added a commit
that referenced
this pull request
May 21, 2024
* consortium-v2: implement RLP encoding for header extra data * consortium-v2: integrate new RLP encoder/decoder for header extra data * consortium-v2: optimize extra data rlp encoding * consortium-v2: benchmark for new rlp encoding * consortium-v2: clean up unit test --------- Co-authored-by: Bui Quang Minh <[email protected]>
Francesco4203
pushed a commit
to Francesco4203/ronin
that referenced
this pull request
Jun 18, 2024
…ity#415) * consortium-v2: implement RLP encoding for header extra data * consortium-v2: integrate new RLP encoder/decoder for header extra data * consortium-v2: optimize extra data rlp encoding * consortium-v2: benchmark for new rlp encoding * consortium-v2: clean up unit test --------- Co-authored-by: Bui Quang Minh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, HeaderExtraData is encoded/decoded manually, which is error prone and hard to extend. Hence, this PR implements a new RLP encoder/decoder for HeaderExtraData and changes to use this new method.