Update circuit logic and readme #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ytham
commented
Jan 16, 2024
ytham
commented
- Updates circuit logic to remove nondeterminism
- Updates readme
yi-sun
requested changes
Jan 16, 2024
| @@ -29,10 +33,11 @@ export const circuit = async (inputs: CircuitInputs) => { | |||
| throw new Error("Block number must be greater than the number of samples times the spacing"); | |||
| } | |||
|
|
|||
| // Create an array of block numbers to sample from | |||
There was a problem hiding this comment.
We should also validate inputs.blockNumber.value() <= (samples * spacing) in ZK
yi-sun
added a commit
that referenced
this pull request
Jan 20, 2024
* New quickstart flow * fix: foundry install -> forge install * checkpoint * feat: prototype test * feat: checkpoint * forge install: axiom-v2-contracts-working * forge install: axiom-v2-contracts-working v0.5.0-rc2 * feat: add first working prototype of AxiomTest * forge install: axiom-v2-client * feat: read AxiomTest from axiom-v2-client, add dependency * chore: update for path change in axiom-v2-client * chore: update axiom-v2-client version and paths * feat: update to new v2-client * feat: update imports * feat: update for axiom-v2-client updates * Update quickstart for new flow * Update example client addr * feat: reconcile directory structure * chore: add Github CI * feat: update README.md * feat: update private key to Sepolia * feat: update deploy script * feat: get index.ts running * merge * fix: update remappings * feat: merge * chore: remove some references to Goerli * Merge branch `test/compile` into `staging` (#8) * WIP * New flow * Update example circuit * update axiom-v2-client * chore: turn on CI for staging * Update circuit logic and readme (#9) * Make circuit deterministic * Update readme * Add circuit block number check * chore: update to latest version of axiom-v2-client (#10) * fix foundry.toml (#11) * chore: update to latest version of axiom-v2-client * chore: add remappings to foundry.toml * fix: keep opther remappings * Use new client version (#14) * Simplify circuit code and add callback target * Update client version * Update comments * Update comments * Use automatic gas detection * Update to remove mock * Update client package * Update axiom-v2-client * Remove args logging * Remove mock * Update circuit * Remove unused input.json fileg (#15) * Remove unused shell script (#16) * feat: update for axiom-v2-client to axiom-v2-periphery renaming (#17) * feat: remove axiom-v2-client * forge install: axiom-v2-periphery * feat: update for axiom-v2-client to axiom-v2-periphery renaming --------- Co-authored-by: Yu Jiang Tham <[email protected]> Co-authored-by: roshan <[email protected]> Co-authored-by: Yu Jiang Tham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.