Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert evm::evm_verify to be fallible #69

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Convert evm::evm_verify to be fallible #69

merged 1 commit into from
Jan 25, 2025

Conversation

roynalnaruto
Copy link

@roynalnaruto roynalnaruto commented Jan 25, 2025 •
edited
Loading

Change function signature to make evm::evm_verify fallible. Eventually can be used in openvm_sdk::verify_evm_proof to return the Result (instead of the current infallible approach).

If merged, I can open a pull request to openvm_sdk

jonathanpwang
jonathanpwang approved these changes Jan 25, 2025
View reviewed changes
Copy link

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanpwang jonathanpwang merged commit ab65fda into axiom-crypto:zkvm-v0.1 Jan 25, 2025
2 checks passed
@roynalnaruto roynalnaruto mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roynalnaruto @jonathanpwang