Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Finish apply_dist() #1730

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

(WIP) Finish apply_dist() #1730

wants to merge 15 commits into from

Conversation

duckinator
Copy link
Contributor

@duckinator duckinator commented Jan 28, 2025 •
edited
Loading

TODO:

Verify each of the following submodules under dist::init::apply_dist handle all configuration values:

  • artifacts
    • archives (ArchiveLayer)
      • include
      • auto_includes
      • windows_archive
      • unix_archive
      • package_libraries
    • source_tarball
    • extra (deliberately not done)
    • checksum
    • tests
  • builds
    • common (CommonBuildLayer; empty struct)
    • ssldotcom_windows_sign
    • macos_sign
    • cargo (BoolOr CargoBuildLayer)
      • ?
    • generic (BoolOr GenericBuildLayer)
      • ?
    • system_dependencies (SystemDependencies) (maybe rename apply_dist/{,builds/}system_dependencies.rs?)
      • ?
    • min_glibc_version
    • omnibor
    • tests
  • ci
    • common (CommonCiLayer)
      • merge_tasks
      • fail_fast
      • cache_builds
      • build_local_artifacts
      • dispatch_releases
      • release_branch
      • pr_run_mode
      • tag_namespace
      • plan_jobs
      • build_local_jobs
      • build_global_jobs
      • host_jobs
      • publish_jobs
      • post_announce_jobs
    • github
      • common (CommonCiLayer)
      • runners (deliberately not done)
      • permissions (deliberately not done)
      • build_setup
    • tests
  • hosts
    • common (CommonHostLayer)
    • force_latest
    • display
    • display_name
    • github (BoolOr GithubHostLayer)
      • ?
    • axodotdev (BoolOr AxodotdevHostLayer)
      • ?
    • tests
  • installers
    • common (CommonInstallerLayer)
      • install_path
      • install_success_msg
      • install_libraries
      • bin_aliases (deliberately not done)
    • homebrew (BoolOr HomebrewInstallersLayer)
      • Bool
      • common
      • tap
      • formula
    • msi (BoolOr MsiInstallerLayer)
      • Bool
      • common
    • npm (BoolOr NpmInstallerLayer)
      • Bool
      • common
      • package
      • scope
    • powershell (BoolOr PowershellInstallerLayer)
      • Bool
      • common
    • shell (BoolOr ShellInstallerLayer)
      • Bool
      • common
    • pkg (BoolOr PkgInstallerLayer)
      • Bool
      • common
      • identifier
      • install_location
    • updater
    • always_use_latest_updater
    • tests
  • publishers
    • common (CommonPublisherLayer)
      • prereleases
    • homebrew (BoolOr HomebrewPublisherLayer)
      • common
    • npm (BoolOr NpmPublisherLayer)
      • common
    • tests

@duckinator duckinator mentioned this pull request Jan 28, 2025
Draft
5 tasks
@duckinator duckinator changed the title [WIP] Finish apply_dist() (WIP) Finish apply_dist() Jan 29, 2025
@duckinator
Copy link
Contributor Author

Split some changes off to init-v1-wip

@duckinator duckinator force-pushed the apply-dist branch 3 times, most recently from e3bdcf2 to 1b6e08b Compare February 5, 2025 19:51
@duckinator
Copy link
Contributor Author

Rebased off main (97661c3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duckinator