-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gen: run automatically #1168
gen: run automatically #1168
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
610606a
to
89602bd
Compare
02900ea
to
2ab4a8f
Compare
d371ae2
to
1e93a40
Compare
7c219c0
to
b6b8dd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks. The only thing that really needs changing IMHO is adding a PR title
and body
. Otherwise LGTM
Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @tamird)
.github/workflows/gen.yml
line 19 at r1 (raw file):
set -euxo pipefail git fetch origin git checkout origin/HEAD
As a follow up, I think we should pin the libbpf version and make this workflow on: workflow_call
.
Since it would then be idempotent it would be safe to call from the main ci.yml
and as a result we wouldn't need to run this workflow manually anymore!
.github/workflows/gen.yml
line 40 at r1 (raw file):
with: branch: create-pull-request/codegen commit-message: |
As above, please also set the PR title
and body
.github/workflows/ci.yml
line 63 at r1 (raw file):
with: branch: create-pull-request/public-api commit-message: "public-api: regenerate"
While you're here, would you please also set title
and body
?
This will ensure the PR is more descriptive than "Changes by create-pull-request action" as in #1169
@tamird, this pull request is now in conflict and requires a rebase. |
b6b8dd4
to
1423c25
Compare
a50a34e
to
f3b5ffa
Compare
bindgen can handle these macros now.
Move some code out of a loop, where it appears to be nonsense.
We already use this for the lint job on main.
libbpf is a submodule, so its version is already effectively pinned. `xtask codegen` also runs `git submodule update` which reverts the action of updating to `origin/HEAD`. Remove the cruft.
f3b5ffa
to
1f00b26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @tamird)
We already use this for the lint job on main.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)