Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen: run automatically #1168

Merged
merged 6 commits into from
Feb 5, 2025
Merged

gen: run automatically #1168

merged 6 commits into from
Feb 5, 2025

Conversation

tamird
Copy link
Member

@tamird tamird commented Feb 4, 2025

We already use this for the lint job on main.


This change is Reviewable

@tamird tamird requested a review from dave-tucker February 4, 2025 20:05
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f00b26
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/67a363e6754a59000839e018
😎 Deploy Preview https://deploy-preview-1168--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the test A PR that improves test cases or CI label Feb 4, 2025
@tamird tamird force-pushed the gen-peter-evans-pr branch 3 times, most recently from 610606a to 89602bd Compare February 4, 2025 20:21
@tamird tamird force-pushed the gen-peter-evans-pr branch 4 times, most recently from 02900ea to 2ab4a8f Compare February 4, 2025 21:22
@mergify mergify bot added aya-bpf This is about aya-bpf (kernel) aya-obj Relating to the aya-obj crate labels Feb 4, 2025
@tamird tamird force-pushed the gen-peter-evans-pr branch from d371ae2 to 1e93a40 Compare February 4, 2025 22:20
@mergify mergify bot added the aya-tool Relating to aya-tool label Feb 4, 2025
@tamird tamird force-pushed the gen-peter-evans-pr branch 5 times, most recently from 7c219c0 to b6b8dd4 Compare February 4, 2025 22:46
@mergify mergify bot added the aya This is about aya (userspace) label Feb 4, 2025
Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks. The only thing that really needs changing IMHO is adding a PR title and body. Otherwise LGTM

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @tamird)


.github/workflows/gen.yml line 19 at r1 (raw file):

          set -euxo pipefail
          git fetch origin
          git checkout origin/HEAD

As a follow up, I think we should pin the libbpf version and make this workflow on: workflow_call.
Since it would then be idempotent it would be safe to call from the main ci.yml and as a result we wouldn't need to run this workflow manually anymore!


.github/workflows/gen.yml line 40 at r1 (raw file):

        with:
          branch: create-pull-request/codegen
          commit-message: |

As above, please also set the PR title and body


.github/workflows/ci.yml line 63 at r1 (raw file):

        with:
          branch: create-pull-request/public-api
          commit-message: "public-api: regenerate"

While you're here, would you please also set title and body?
This will ensure the PR is more descriptive than "Changes by create-pull-request action" as in #1169

Copy link

mergify bot commented Feb 5, 2025

@tamird, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Feb 5, 2025
@tamird tamird force-pushed the gen-peter-evans-pr branch from b6b8dd4 to 1423c25 Compare February 5, 2025 11:30
@mergify mergify bot removed the needs-rebase label Feb 5, 2025
@tamird tamird force-pushed the gen-peter-evans-pr branch 3 times, most recently from a50a34e to f3b5ffa Compare February 5, 2025 11:51
bindgen can handle these macros now.
Move some code out of a loop, where it appears to be nonsense.
We already use this for the lint job on main.
libbpf is a submodule, so its version is already effectively pinned.
`xtask codegen` also runs `git submodule update` which reverts the
action of updating to `origin/HEAD`. Remove the cruft.
@tamird tamird force-pushed the gen-peter-evans-pr branch from f3b5ffa to 1f00b26 Compare February 5, 2025 13:13
@tamird tamird requested a review from dave-tucker February 5, 2025 14:58
Copy link
Member

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @tamird)

@tamird tamird merged commit 8af5f38 into aya-rs:main Feb 5, 2025
31 of 32 checks passed
@tamird tamird changed the title gen: use peter-evans/create-pull-request@v7 gen: run automatically Feb 5, 2025
@tamird tamird deleted the gen-peter-evans-pr branch February 5, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel) aya-obj Relating to the aya-obj crate aya-tool Relating to aya-tool test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants