aya-log: Add *max_level_* filter features
#399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Add the following features for configuring the maximum log level available: * `max_level_off` * `max_level_error` * `max_level_warn` * `max_level_info` * `max_level_debug` * `max_level_trace` * `release_max_level_off` * `release_max_level_error` * `release_max_level_warn` * `release_max_level_info` * `release_max_level_debug` * `release_max_level_trace` Log invocations at disabled level will be skipped, which is especially beneficial for eBPF programs which are not going to send unneceessary logs through perf buffers. Features with `release_` prefix are used only in release builds. Those features have to applied on the userspace and eBPF crate separately. The correct thing to do is to set them on the same level. In case when userspace has higher maximum log level, it's not going to recieve the logs beyond the filter in eBPF crate. In the opposite situation, when eBPF crate has higher maximum level, it's going to waste cycles on sending logs through perf buffer, while they are not going to be displayed in the userspace. Signed-off-by: Michal Rostecki <[email protected]>
alessandrod
reviewed
Nov 9, 2022
| } else if let Some(level) = args.level { | ||
| // Level was chosen by passing an argument to the log! macro. | ||
| // We need to apply the max log level filter here. | ||
| let level_str = format!("{:?}", level); |
There was a problem hiding this comment.
Instead of doing this, the Level enum should be parseable from a TokenStream (using syn::parse::Parse), so we don't have to do this string hack
|
@vadorovsky, this pull request is now in conflict and requires a rebase. |
|
@vadorovsky, this pull request is now in conflict and requires a rebase. |
|
@vadorovsky, this pull request is now in conflict and requires a rebase. |
|
@vadorovsky do you intend to continue with this? I think it would be really great to have in aya-log 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following features for configuring the maximum log level available:
max_level_offmax_level_errormax_level_warnmax_level_infomax_level_debugmax_level_tracerelease_max_level_offrelease_max_level_errorrelease_max_level_warnrelease_max_level_inforelease_max_level_debugrelease_max_level_traceLog invocations at disabled level will be skipped, which is especially beneficial for eBPF programs which are not going to send unneceessary logs through perf buffers.
Features with
release_prefix are used only in release builds.Those features have to applied on the userspace and eBPF crate separately. The correct thing to do is to set them on the same level. In case when userspace has higher maximum log level, it's not going to recieve the logs beyond the filter in eBPF crate. In the opposite situation, when eBPF crate has higher maximum level, it's going to waste cycles on sending logs through perf buffer, while they are not going to be displayed in the userspace.
Signed-off-by: Michal Rostecki [email protected]
This change is