Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment out SymbolResolver to a trait #715

Merged
merged 9 commits into from
Aug 2, 2023
Merged

Segment out SymbolResolver to a trait #715

merged 9 commits into from
Aug 2, 2023

Conversation

addisoncrump
Copy link
Contributor

Makes symbol resolution a trait. Begins to address #705 and extend #339, allows users to define custom implementations in the meantime.

@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ed11eb1
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/64ca6cfa9d125e0008a88531
😎 Deploy Preview https://deploy-preview-715--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the aya This is about aya (userspace) label Aug 1, 2023
@addisoncrump
Copy link
Contributor Author

addisoncrump commented Aug 1, 2023 •
edited
Loading

The public API changes should not affect any downstream users. There is one exception: if the user uses .collect() on 2-tuple iterator to create the BTreeMap, it won't be able to infer the type.

tamird
tamird reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run cargo xtask public-api to regenerate the public API fixture.

@mergify
Copy link

mergify bot commented Aug 2, 2023

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot requested a review from alessandrod August 2, 2023 10:57
@mergify mergify bot added api/needs-review Makes an API change that needs review test A PR that improves test cases or CI labels Aug 2, 2023
alessandrod
alessandrod reviewed Aug 2, 2023
View reviewed changes
tamird
tamird reviewed Aug 2, 2023
View reviewed changes
@tamird
Copy link
Member

tamird commented Aug 2, 2023

LGTM. @dave-tucker should have a look. Please squash the commits.

tamird
tamird reviewed Aug 2, 2023
View reviewed changes
@addisoncrump
Copy link
Contributor Author

Build failure due to an upstream crate. That version is now yanked and this should work again.

@tamird tamird merged commit d8709de into aya-rs:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamird tamird tamird left review comments

@alessandrod alessandrod alessandrod approved these changes

@dave-tucker dave-tucker dave-tucker approved these changes

Assignees
No one assigned
Labels
api/needs-review Makes an API change that needs review aya This is about aya (userspace) test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addisoncrump @tamird @alessandrod @dave-tucker