made several changes to smooth out animation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah that makes sense, I tested it a bit last night and I’m pretty happy with it. Definitely the route I’d want to take, maybe even could use both by detecting the type of browser since the previous one worked on Firefox. I’ll do a deeper dive into it today and will update you with my thoughts. Also, thank you as well! I was definitely scratching my head over this issue and I really appreciate the contribution, glad you’re also getting something out of it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems with the choppiness were that there were too many things being transitioned. The fix was to load the box-shadows as pseudo elements and make the unused one's opacity = 0. This makes them already loaded and much easier on the browser. I changed some of the JS to make it a little cleaner, too. I'm in the process of learning so it might not be to your liking. Your animation was much more interesting, but I made one for you to look at performance-wise. Thanks for letting this be my first real project to contribute to.