Add HTML render of colors #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add HTML render of colors sincce SVG render breaks across devices [scripts/build.html, colors.html] - removed unnecessary import [scripts/build-svg.js] - modified README.md to include link to HTML render - added HTML render to npm scripts [package.json]
- forgot that HTML doesn't preview directly in GitHub - the link to my repo is temporary and will be changed in the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25 and #13.
Problem:
colors.svgbreaks on different devices using different fonts because individual elements use fixed geometry and position. Previous attempts to fix this only display correctly on the fonts that the PR authors have available on their devices, but still break.I use this theme in a lot of my configs and it's become pretty annoying to have to colorpick every color instead of copying it from the SVG.
Solution:
This PR adds a script that generates an HTML render of the colors for consistent, not-broken viewing across devices. Plus, everything is copy-able.
Before merging, the link will be replaced with: https://htmlpreview.deno.dev/?url=https://raw.githubusercontent.com/ayu-theme/ayu-colors/master/colors.htmlEDIT: Link broke, you can view it here now (or just download it from my repo if you want) https://skybldev.eu.org/d/ayu-colors.html