Skip to content

implement fluid_shape and outline_shape #2058

implement fluid_shape and outline_shape

implement fluid_shape and outline_shape #2058

Triggered via push December 27, 2024 12:30
Status Success
Total duration 1m 52s
Artifacts

check.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

17 warnings
operator precedence can trip the unwary: azalea/src/pathfinder/world.rs#L266
warning: operator precedence can trip the unwary --> azalea/src/pathfinder/world.rs:266:13 | 266 | (pos.x as usize & 0xff) << 12 | (pos.y as usize & 0xf) << 8 | (pos.z as usize & 0xff); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((pos.x as usize & 0xff) << 12) | ((pos.y as usize & 0xf) << 8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `#[warn(clippy::precedence)]` on by default
operator precedence can trip the unwary: azalea-protocol/src/packets/game/c_section_blocks_update.rs#L39
warning: operator precedence can trip the unwary --> azalea-protocol/src/packets/game/c_section_blocks_update.rs:39:16 | 39 | | (u64::from(self.pos.x) << 8 | u64::from(self.pos.z) << 4 | u64::from(self.pos.y)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(u64::from(self.pos.x) << 8) | (u64::from(self.pos.z) << 4)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-protocol/src/packets/game/c_section_blocks_update.rs#L38
warning: operator precedence can trip the unwary --> azalea-protocol/src/packets/game/c_section_blocks_update.rs:38:20 | 38 | let data = (self.state.id as u64) << 12 | ____________________^ 39 | | | (u64::from(self.pos.x) << 8 | u64::from(self.pos.z) << 4 | u64::from(self.pos.y)); | |_______________________________________________________________________________________________^ help: consider parenthesizing your expression: `((self.state.id as u64) << 12) | (u64::from(self.pos.x) << 8 | u64::from(self.pos.z) << 4 | u64::from(self.pos.y))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-protocol/src/packets/game/c_section_blocks_update.rs#L30
warning: operator precedence can trip the unwary --> azalea-protocol/src/packets/game/c_section_blocks_update.rs:30:17 | 30 | z: (position_part >> 4 & 15) as u8, | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(position_part >> 4) & 15` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-protocol/src/packets/game/c_section_blocks_update.rs#L28
warning: operator precedence can trip the unwary --> azalea-protocol/src/packets/game/c_section_blocks_update.rs:28:17 | 28 | x: (position_part >> 8 & 15) as u8, | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(position_part >> 8) & 15` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `#[warn(clippy::precedence)]` on by default
operator precedence can trip the unwary: azalea-world/src/bit_storage.rs#L209
warning: operator precedence can trip the unwary --> azalea-world/src/bit_storage.rs:209:17 | 209 | *cell = *cell & !(self.mask << bit_index) | (value & self.mask) << bit_index; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `*cell & !(self.mask << bit_index) | ((value & self.mask) << bit_index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-world/src/bit_storage.rs#L194
warning: operator precedence can trip the unwary --> azalea-world/src/bit_storage.rs:194:17 | 194 | *cell = *cell & !(self.mask << bit_index) | (value & self.mask) << bit_index; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `*cell & !(self.mask << bit_index) | ((value & self.mask) << bit_index)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-world/src/bit_storage.rs#L193
warning: operator precedence can trip the unwary --> azalea-world/src/bit_storage.rs:193:25 | 193 | let old_value = *cell >> (bit_index as u64) & self.mask; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(*cell >> (bit_index as u64)) & self.mask` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-world/src/bit_storage.rs#L179
warning: operator precedence can trip the unwary --> azalea-world/src/bit_storage.rs:179:9 | 179 | cell >> bit_index & self.mask | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(cell >> bit_index) & self.mask` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `#[warn(clippy::precedence)]` on by default
operator precedence can trip the unwary: azalea-core/src/color.rs#L36
warning: operator precedence can trip the unwary --> azalea-core/src/color.rs:36:20 | 36 | value: (a as u32) << 24 | (r as u32) << 16 | (g as u32) << 8 | b as u32, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((a as u32) << 24) | ((r as u32) << 16)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-core/src/color.rs#L36
warning: operator precedence can trip the unwary --> azalea-core/src/color.rs:36:20 | 36 | value: (a as u32) << 24 | (r as u32) << 16 | (g as u32) << 8 | b as u32, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(a as u32) << 24 | (r as u32) << 16 | ((g as u32) << 8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
operator precedence can trip the unwary: azalea-core/src/color.rs#L11
warning: operator precedence can trip the unwary --> azalea-core/src/color.rs:11:20 | 11 | value: (r as u32) << 16 | (g as u32) << 8 | b as u32, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((r as u32) << 16) | ((g as u32) << 8)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence = note: `#[warn(clippy::precedence)]` on by default
clippy_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/