Clippy check

implement climbing ladders/vines #1616

Triggered via push December 10, 2023 05:34

mat-1

pushed 3c70e24

climbing

Status Success

Total duration 1m 55s

Artifacts –

check.yml

on: push

clippy_check

1m 44s

Annotations

27 warnings

this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/lib.rs#L267

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/lib.rs:267:62 | 267 | physics.velocity = handle_on_climbable(physics.velocity, &on_climbable, &position, world, pose); | ^^^^^^^^^^^^^ help: change this to: `on_climbable` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this function has too many arguments (10/7): azalea-physics/src/lib.rs#L243

warning: this function has too many arguments (10/7) --> azalea-physics/src/lib.rs:243:1 | 243 | / fn handle_relative_friction_and_calculate_movement( 244 | | block_friction: f32, 245 | | world: &Instance, 246 | | physics: &mut Physics, ... | 254 | | jumping: &Jumping, 255 | | ) -> Vec3 { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: azalea-physics/src/collision/mod.rs#L195

warning: this expression creates a reference which is immediately dereferenced by the compiler --> azalea-physics/src/collision/mod.rs:195:72 | 195 | let _block_pos_below = azalea_entity::on_pos_legacy(&world.chunks, &position); | ^^^^^^^^^ help: change this to: `position` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

this if-then-else expression assigns a bool literal: azalea-entity/src/plugin/mod.rs#L138

warning: this if-then-else expression assigns a bool literal --> azalea-entity/src/plugin/mod.rs:138:16 | 138 | } else if azalea_registry::tags::blocks::TRAPDOORS.contains(&registry_block_at_feet) | ________________^ 139 | | && is_trapdoor_useable_as_ladder(block_state_at_feet, block_pos, &instance) 140 | | { 141 | | **on_climbable = true; 142 | | } else { 143 | | **on_climbable = false; 144 | | } | |_________^ help: you can reduce it to: `**on_climbable = azalea_registry::tags::blocks::TRAPDOORS.contains(&registry_block_at_feet) && is_trapdoor_useable_as_ladder(block_state_at_feet, block_pos, &instance);` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign = note: `#[warn(clippy::needless_bool_assign)]` on by default

this `if` has identical blocks: azalea-entity/src/plugin/mod.rs#L136

warning: this `if` has identical blocks --> azalea-entity/src/plugin/mod.rs:136:87 | 136 | if azalea_registry::tags::blocks::CLIMBABLE.contains(&registry_block_at_feet) { | _______________________________________________________________________________________^ 137 | | **on_climbable = true; 138 | | } else if azalea_registry::tags::blocks::TRAPDOORS.contains(&registry_block_at_feet) | |_________^ | note: same as this --> azalea-entity/src/plugin/mod.rs:140:9 | 140 | / { 141 | | **on_climbable = true; 142 | | } else { | |_________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[warn(clippy::if_same_then_else)]` on by default

this creates an owned instance just for comparison: azalea-block/azalea-block-macros/src/lib.rs#L538

warning: this creates an owned instance just for comparison --> azalea-block/azalea-block-macros/src/lib.rs:538:54 | 538 | .find(|v| v.ident.to_string() == variant.to_string()); | -----------------------^^^^^^^^^^^^^^^^^^^ | | | help: try: `variant == v.ident.to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned

this creates an owned instance just for comparison: azalea-block/azalea-block-macros/src/lib.rs#L538

warning: this creates an owned instance just for comparison --> azalea-block/azalea-block-macros/src/lib.rs:538:31 | 538 | .find(|v| v.ident.to_string() == variant.to_string()); | ^^^^^^^^^^^^^^^^^^^ help: try: `v.ident` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned = note: `#[warn(clippy::cmp_owned)]` on by default

use of `or_insert_with` to construct default value: azalea-block/azalea-block-macros/src/lib.rs#L535

warning: use of `or_insert_with` to construct default value --> azalea-block/azalea-block-macros/src/lib.rs:535:22 | 535 | .or_insert_with(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

this creates an owned instance just for comparison: azalea-block/azalea-block-macros/src/lib.rs#L538