Fix tslint whitespace issue in Jenkins env

[CloudNiner]

Overview

tslint throws a "missing whitespace" error in the jsdoc comment of image-export.service.ts, but only in the jenkins environment.

This issue is tracked here: palantir/tslint#3251 and a scan through the comments indicates a general 🤷 that its caused by some magic combination of node + npm+ yarn + typescript + tslint + tsutils and that updating to yarn 1.2+ fixes it. I attempted this upgrade in place while SSHed into Jenkins but had no luck. I might have done something wrong getting node_modules cleaned out though.

So, for now I just removed the whitespace.check-separator in tslint as a workaround. I'm hopeful that a separate task to update yarn in the docker container on Jenkins would address the deeper issue. Edit: first attempting a yarn version upgrade on fresh Jenkins build.

Created #325 to more thoroughly fix the issue.

Testing Instructions

Jenkins should now build successfully.

Checklist

• yarn run serve clean?
• yarn run build:prod clean?
• yarn run lint clean?

[fungjj92]

Now that Jenkins is passing unexpectedly without this PR -- begs the question now, is this even necessary? Is Jenkins fooling us? Is it a different issue? 😥

[CloudNiner]

Yuck I know. I don't believe its necessary, I'd prefer to not have to disable a fairly useful linter check. But, I have no idea what changed that would have fixed the problem. If jenkins remains stable throughout the day I'll just close this with a relevant comment on #325.

[CloudNiner]

Since Jenkins unfixed itself after a short period of time, I'm going to merge this so that builds return to a consistent state. We can address the root cause in the followup issue at a later time.