Validate item times match collection periodicity when present #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made some ad hoc choices here, like "items have to be point-in-time items rather than time range items", but I think these make sense.
|
CI's gonna fail until I get on a real |
jisantuc
changed the title
This reverts commit 7f21df3. turns out it wasn't the launcher script's fault
|
468e301 addresses the issue discovered in demo today |
pomadchin
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr links up collection extent periodicity with the validation changes introduced in #664. It doesn't work yet and has some unimplemented bits, but types line up and it's what things will look like ✨eventually✨.
Checklist
Notes
This wound up requiring changes in several places:
The function for checking alignment is a bit complicated, so I added a number of tests in
PeriodAlignmentSpec.scala. There aren't tests for periods smaller than weeks. Because weeks, months, and years are the messiest cases, I focused there, and fortunately everything worked as expected. I'll demo at the weekly check-in tomorrow.Testing Instructions
Closes #637