New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change string format #27

Merged

Helias merged 1 commit into azerothcore:master from PaoloBenigni:master

Oct 3, 2024

PaoloBenigni commented Oct 2, 2024 •

edited

Loading

Modified string format to fix error.

Changes Proposed:

Change format in strings from %s to {}

Issues Addressed:

Closes unreported, but observed issue

SOURCE:

Tests Performed:

Test builds correctly, and confirmed that this works inhouse.
Build was on Ubuntu.

How to Test the Changes:

Craft an uncommon or greater items, observe that the change has taken place.
Loot an uncommon or greater item
Unsure if a gm add command would also make this work.


          Change string format

4b3e033

Modified string format to fix error.

Helias approved these changes

View reviewed changes

Member

Helias commented Oct 3, 2024

Ciao 👋 , I will merge the PR if the build pass

Helias merged commit 67a1fbb into azerothcore:master

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet