Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change language to english #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tarawow
Copy link

@tarawow tarawow commented Sep 20, 2024

Changes Proposed:

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

@pangolp
Copy link

pangolp commented Sep 20, 2024

Instead of changing it to English, what I would do is keep both files. The README.md in English, and the README_ES.md in Spanish. Many modules have this, so that those of us who do not use English can also have a description of what the module does.

@Helias
Copy link
Member

Helias commented Sep 20, 2024

Instead of changing it to English, what I would do is keep both files. The README.md in English, and the README_ES.md in Spanish. Many modules have this, so that those of us who do not use English can also have a description of what the module does.

we could keep the config in English and the readme in both languages

@pangolp
Copy link

pangolp commented Sep 20, 2024

Instead of changing it to English, what I would do is keep both files. The README.md in English, and the README_ES.md in Spanish. Many modules have this, so that those of us who do not use English can also have a description of what the module does.

we could keep the config in English and the readme in both languages

Yes, I was talking about the README

@pangolp
Copy link

pangolp commented Sep 20, 2024

If you give me time, I'll make a commit on the change I'm mentioning.

@pangolp
Copy link

pangolp commented Sep 21, 2024

@tarawow the future, as a recommendation, I would create a new branch when making a pull request, otherwise your branch will never match the parent's history. Although it is a detail that I really don't know if it makes sense, it is just a recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants